fix: Problems' description (pick, edit) #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed a key to fix parsing daily problem request. Fixed when id for daily problem should be fetched. Before, it will always be fetched for the `pick` option regardless of the existence of the `-d` option
Changed desc comment to render Question.content instead of Question.t_content, which was empty.
tripercy
changed the title
|
hi @tripercy , thanks for contributing! please ping me when you finish the PR |
|
Hey @clearloop , the PR is already finished, you can review it. P/S: Great repo btw, thank you for putting the it together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a key to fix parsing of daily problem request (dailyQuestionRecord -> activeDailyCodingChallengeQuestion).
Fixed when id for daily problem should be fetched. Before, it will always be fetched for the
pickoption regardless of the existence of the-doptionFixed comment problem desc to correctly add problem description by changing the Question to render
Question.contentinstead ofQuestion.t_content(which was empty).